Allow prebuilt-NASM w/ Cmake toolchain #852
Open
+95
−34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #852 +/- ##
==========================================
- Coverage 95.80% 92.30% -3.50%
==========================================
Files 61 71 +10
Lines 8143 9276 +1133
Branches 0 9276 +9276
==========================================
+ Hits 7801 8562 +761
- Misses 342 434 +92
- Partials 0 280 +280 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
justsmth
force-pushed
the
prebuilt-NASM-w-cmake-toolchain
branch
3 times, most recently
from
028de95 to
64746a3
Compare
justsmth
changed the title
justsmth
force-pushed
the
prebuilt-NASM-w-cmake-toolchain
branch
from
64746a3 to
a6b23b4
Compare
justsmth
force-pushed
the
prebuilt-NASM-w-cmake-toolchain
branch
2 times, most recently
from
6c14408 to
aafe584
Compare
justsmth
force-pushed
the
prebuilt-NASM-w-cmake-toolchain
branch
from
aafe584 to
5f7f04a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues:
Addresses #850
Description of changes:
Allow use of prebuilt-NASM objects even when a CMake toolchain was specified.
Call-outs:
We should consider whether to differentiate
AWS_LC_SYS_PREBUILT_NASMbeing set in the environment from having the "prebuilt-nasm" feature enabled. Perhaps when a CMake toolchain is specified, we should only consider whetherAWS_LC_SYS_PREBUILT_NASMis also specified when determining whether to use prebuilt NASM objects.Testing:
Added tests.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.